fix: increase tap target sizes to satisfy Lighthouse accessibility#258
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
This PR adjusts site CSS to enlarge interactive elements’ tap/click areas, aiming to address Lighthouse accessibility findings related to tap target sizing.
Changes:
- Increased header navigation link tap targets via
min-height+ padding and flex alignment (.hero-header a). - Increased footer social icon tap targets via
min-width/min-height+ padding and centering (.social-icon). - Added/updated footer contact link and “support link” (Buy Me A Coffee) sizing rules to ensure minimum tap target dimensions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates assets/css/style.css to improve the tap target sizes of various links and icons, including header links, social icons, and footer contact links, by setting flex properties, padding, and minimum dimensions of 44px. The reviewer recommends increasing these minimum dimensions to 48px × 48px to fully comply with Google Lighthouse accessibility guidelines for mobile tap targets.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
J'approuve la correction Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
J'approuve la correction Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
J'approuve la correction Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@copilot resolve the merge conflicts in this pull request |
Les conflits de fusion ont été résolus — commit |
name: Pull Request
about: Proposer un changement au projet
title: ''
labels: ''
assignees: ''
1. Quels sont les changements ?
Résumé des changements :
(Décrivez brièvement les modifications apportées.)
Tickets / Issues liés :
2. Pourquoi ces changements ?
Contexte métier :
(Expliquez la raison fonctionnelle ou business de ces changements.)
Justification technique :
(Expliquez les choix d'architecture ou d'implémentation retenus.)
3. Tests
Tests unitaires :
npm test/bundle exec rspec/ …)Tests manuels :
Performances & Sécurité :
4. Changements majeurs (Breaking Changes)
Cette PR introduit-elle des ruptures d'API ou de comportement ?
(Décrivez les ruptures et les impacts pour les consommateurs de l'API / les autres équipes.)
Instructions de migration :
(Si applicable, décrivez les étapes nécessaires pour migrer.)
5. Exigences de déploiement
Variables d'environnement :
NOM_VARvaleurNotes de déploiement supplémentaires :
(Toute information utile pour l'équipe de déploiement.)